Start porting 2.2.x compat #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
xnox
commented
May 30, 2023
| @@ -122,7 +122,7 @@ int dataset_clone(dataset_list_ptr dataset, const char *target, nvlist_ptr props | |||
| int dataset_snapshot(const char *path, boolean_t recur, nvlist_ptr props); | |||
| int dataset_rollback(dataset_list_ptr dataset, dataset_list_ptr snapshot, boolean_t force); | |||
| int dataset_promote(dataset_list_ptr dataset); | |||
| int dataset_rename(dataset_list_ptr dataset, const char* new_name, boolean_t recur, boolean_t force_unm); | |||
| int dataset_rename(dataset_list_ptr dataset, const char* new_name, boolean_t recur, boolean_t no_unm, boolean_t force_unm); | |||
There was a problem hiding this comment.
not sure if this is ok, or if it best to mimick the new C api, and actually create renameflags_t and expose it.
There was a problem hiding this comment.
note sure if this is still maintained.
if we have to fork anyway, what about just removing the broken interfaces?
|
Is this related to #49 ? |
Closed
|
the test failure is due to new pool props |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zfs-linux development branch (version set to 2.1.99, to become 2.2.x series) has a few chnages that prevent go-libzfs form compiling.
I have attempted to start porting it over, however it seems like many operations are incompatible. This no passes
go buildbut failsgo test. Will debug further.