-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bep018 #828
Conversation
…n tests. Fix array push call for isseu 114
…than a few fields
…ion, update issue codes
Codecov Report
@@ Coverage Diff @@
## master #828 +/- ##
=========================================
Coverage ? 86.69%
=========================================
Files ? 75
Lines ? 2203
Branches ? 454
=========================================
Hits ? 1910
Misses ? 250
Partials ? 43 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rwblair - I have given this a coarse look (not comparing directly with the specification draft yet).
@CPernet could you also have a look at the code and check if some keywords are missing or optional/mandatory keywords are treated appropriately? No specific JS skills needed here, it's very readable.
Another point: Have you tested this on an example dataset @rwblair? If yes, which one? Can we edit a dataset on https://github.com/bids-standard/bids-examples to include genetics information?
I'm finishing a UK biobank example, will push it soon as a PR = we can test the validator |
New specification PR bids-standard/bids-specification/pull/395 for discussion. |
…dded genetic_info to top level file list
@sappelhoff @CPernet has made an example dataset that can be found here: I have a PR from my branch of his examples back to his master that passes using this validator: I figure we merge validator first and then examples? The validator uses the examples in its tests and the examples use the validators in its tests. One of them has to be merged first, the examples will never pass against a specified version of the validator without the necessary changes to the validator being merged. |
@rwblair Let's merge the validator first. |
- [ ] Add valid genetic_info.json to an example dataset.Added valid genetic_info.json else where in tests.