-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: Add MongoDB query and aggregation features to the BigchainDB API. #2690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main repository master in private fork master
Codecov Report
@@ Coverage Diff @@
## master #2690 +/- ##
==========================================
- Coverage 93.32% 93.15% -0.17%
==========================================
Files 46 46
Lines 2712 2777 +65
==========================================
+ Hits 2531 2587 +56
- Misses 181 190 +9 |
Hi @elmadj really appreciate your contribution! It will be reviewed soon. Meanwhile would you mind to add "sing off:" line to your commits? |
Thanks @zzappie . Will do that soon ! |
Signed-off-by: maoudia <maoudia@viascience.com>
…db into query_aggregate_features
…db into query_aggregate_features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
This PR adds two endpoints to the BIgchainDB API:
A "query-assets" endpoint which allows the client to pass a json query as defined by MongoDB to query the assets collection. (https://docs.mongodb.com/manual/tutorial/query-documents/)
An "aggregate-assets" endpoint which allows the client to pass a list of aggregation functions to perform a MongoDB aggregation. (https://docs.mongodb.com/manual/reference/method/db.collection.aggregate/)
BEPs Implemented
bigchaindb/BEPs#96