STRF-3382 display facebook like button when enabled#1530
STRF-3382 display facebook like button when enabled#1530bookernath merged 1 commit intobigcommerce:masterfrom
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
bc-williamkwon
force-pushed
the
facebookLike
branch
3 times, most recently
from
cc8d5d0 to
357ff96
Compare
| {{/if}} | ||
| </div> | ||
| {{> components/common/share}} | ||
| {{#if settings.facebook_like_button}}{{{settings.facebook_like_button}}}{{/if}} |
There was a problem hiding this comment.
Should this go in the common/share component? Do we only want it to show on this page, or anywhere we have the share buttons?
There was a problem hiding this comment.
Facebook like button isn't the same as the other share buttons it's an iframe and not an icon for one. I think it's good to keep them separate also the other share icons are linked to addthisservices but facebook like is not. It also seems to be specifically for the product page.
| {{else}} | ||
| <amp-social-share class="amp-social-share" data-vars-product-link="{{url}}" data-vars-product-id="{{id}}" data-vars-product-name="{{name}}" data-vars-social-type="{{service}}" type="{{service}}"></amp-social-share> | ||
| {{/if}} | ||
| <amp-social-share class="amp-social-share" data-vars-product-link="{{url}}" data-vars-product-id="{{id}}" data-vars-product-name="{{name}}" data-vars-social-type="{{service}}" type="{{service}}"></amp-social-share> |
There was a problem hiding this comment.
It looks like you are blending this change with #1526. Can you separate them?
bc-williamkwon
force-pushed
the
facebookLike
branch
from
357ff96 to
563152b
Compare
mattolson
left a comment
mattolson
left a comment
There was a problem hiding this comment.
We should put the markup for the facebook like button into the theme to allow for better customization.
bc-williamkwon
force-pushed
the
facebookLike
branch
5 times, most recently
from
470816f to
d2e7008
Compare
bc-williamkwon
force-pushed
the
facebookLike
branch
3 times, most recently
from
e0ea153 to
d658954
Compare
| allowTransparency="true"> | ||
| </iframe> | ||
| {{/if}} | ||
| {{/if}} No newline at end of file |
| {{/if}} | ||
| </div> | ||
| {{> components/common/share}} | ||
| {{> components/common/facebook-like-button}} |
There was a problem hiding this comment.
Is there a reason why we can't pull this component inside {{> components/common/share}}
There was a problem hiding this comment.
I thought it would be better to separate it out since everything else is a svg instead of an iframe and they are about sharing whereas this is about liking but no real reason. Also, the majority of share.html is ShowAddThisServices but facebook like isn't part of that.
There was a problem hiding this comment.
@bookernath do you have an opinion on this one ? If not this PR is good to go.
There was a problem hiding this comment.
I like the idea of putting this new component inside the share component.
If I were a theme developer that wanted to move my share icons around on the page, I'd probably expect Facebook to come along for the ride, so I think that would be more convenient.
bc-williamkwon
force-pushed
the
facebookLike
branch
from
d658954 to
ec5bc8b
Compare
bc-williamkwon
force-pushed
the
facebookLike
branch
from
ec5bc8b to
86d26e7
Compare
bc-williamkwon
force-pushed
the
facebookLike
branch
from
86d26e7 to
ebc677a
Compare
5 participants
What?
Display like button when it is enabled through control panel. This pull request is to fix a bug where the facebook like button would not display when enabled.
Tickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
Attach images or add image links here.