Linux+Proton support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replaced OS checks in profiles.py with a dependency injection * Extracted Game_Choice to a separate module (fixes a circular import caused by the above)
* Converted most `os.path` uses into `pathlib.Path`, which is friendlier * Some `os.path`s still exist in Windows-specific code * `get_latest_directory` logic updated to work with Path * Added new exception `SaveDataNotFound` for UserOS
Changed how CONFIG.config_path finds the app's directory path. The Linux PyInstaller onefile now chooses the right place for the config.json.
|
Thanks @JonLiuFYI -- will be giving it a look this week! |
There was a problem hiding this comment.
Finished reviewing and testing the solution. Working great on my Windows machine. Once again really appreciate the stellar work and refactoring! I learned a lot such as Python having built-in abstract base class utilities.
Only have minor suggestions for the README that I do not mind much either way on, so after you review I'll approve, merge, and create a release here as well as on Nexus Mods.
JonLiuFYI
commented
May 22, 2023
Co-authored-by: biggestcookie <5748299+biggestcookie@users.noreply.github.com>
Co-authored-by: biggestcookie <5748299+biggestcookie@users.noreply.github.com>
|
Ship this bad boy. |
biggestcookie
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When complete, this closes #2 and increases the version number to 1.2.
Tasks
profiles.pyAcceptance
After merging
Build and release version 1.2 for