Skip to content

Raise error on nonexistent datasets #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 4, 2022
Merged

Raise error on nonexistent datasets #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9bd1857
fix: raise error on nonexistent datasets
jaketae Dec 6, 2021
e97fe14
style: run linters
jaketae Dec 6, 2021
7964879
fix: warn instead of returning
jaketae Jan 27, 2022
7039562
fix: `logger` -> `logging`
jaketae Jan 27, 2022
880eb22
style: run linter
jaketae Jan 27, 2022
889cb5b
chore: fix typo
jaketae Jan 27, 2022
baadaba
fix: specify subset name if possible
jaketae Jan 27, 2022
ba97965
Update promptsource/templates.py
VictorSanh Feb 4, 2022
99dd469
quick fix for the tests (black dependency)
VictorSanh Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions promptsource/templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import logging
import os
import random
import uuid
Expand Down Expand Up @@ -380,6 +381,11 @@ def read_from_file(self) -> Dict:
"""

if not os.path.exists(self.yaml_path):
dataset_name = f"{self.dataset_name} {self.subset_name}" if self.subset_name else self.dataset_name
logging.warning(
f"Tried instantiating `DatasetTemplates` for {dataset_name}, but no prompts found. "
"Please ignore this warning if you are creating new prompts for this dataset."
)
return {}
yaml_dict = yaml.load(open(self.yaml_path, "r"), Loader=yaml.FullLoader)
return yaml_dict[self.TEMPLATES_KEY]
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
black
black<=21.12b0
datasets>=1.7.0
flake8
isort==5.8.0
Expand Down