Load tests triple store #71
Conversation
Renaming prefix_group to prefix_var as well as alias_group to alias_var
|
Hi @jyucsiro there are a lot of commits on this PR; looking at the commit IDs it looks like this includes changes form #53 and #56 Does this contain all the elements from those pieces of work that you want included? thank you |
| data: | ||
|
|
||
| temp = | ||
| _, _, _, _, _, _, _, _, _, _, _, _, _, _, _, _, _, |
There was a problem hiding this comment.
these 'missing data' elements are not required, ncgen will fill these in for us when it runs, so they can be left out
| data: | ||
|
|
||
| temp = | ||
| _, _, _, _, _, _, _, _, _, _, _, _, _, _, _, _, _, |
There was a problem hiding this comment.
these 'missing data' elements are not required, ncgen will fill these in for us when it runs, so they can be left out
lib/bald/__init__.py
Outdated
|
|
||
| def check_uri(self, uri): | ||
| result = False | ||
| #print("Checking uri: " + uri) |
There was a problem hiding this comment.
please may we remove this commented out print?
lib/bald/__init__.py
Outdated
| for attr in self.attrs: | ||
| objs = self.attrs[attr] | ||
| if(isinstance(objs, np.ndarray)): | ||
| #print("Found np.ndarray") |
There was a problem hiding this comment.
please may we remove these commented out prints?
lib/bald/__init__.py
Outdated
| f.close() | ||
|
|
||
| def load_netcdf(afilepath, uri=None): | ||
| def load_netcdf(afilepath, uri=None, baseuri=None): |
There was a problem hiding this comment.
I am wary that there might be confusion in our code regarding uri and baseuri
what are the differences in use between these two? Can we use the same input for all cases, to guard against confusion?
There was a problem hiding this comment.
I had understood the var 'uri' to be the root_uri of the graph. so there was a gap in an ability to specify a default prefix uri for entities in the graph that weren't qualified, which was the intention of 'baseuri'.
if they are the same, then no problem to merge them...
There was a problem hiding this comment.
i think that there is one concept here and that we would be well served by keeping one concept; i think the subtle distinction may be too hard to explain.
I think i prefer then input name baseuri to uri so I'd advocate using this throughout and having only 1 input parameter
There was a problem hiding this comment.
Your suggestion makes sense Mark. Let's go with that. I've also added a test for RDF graph output with a baseuri so that we're covered for that.
| file_variables = {} | ||
| for name in fhandle.variables: | ||
| #print(name) | ||
| if name == prefix_var_name or name == alias_var_name: |
There was a problem hiding this comment.
this appears to be doing the same as skipped_variables (removed at old l591) but skipped_variables still exists. should it be removed altogether in favour of this pattern, or kept instead of this pattern.
I'd prefer to decide one way or the other and clean up unused code if we can
There was a problem hiding this comment.
it seems like we had developed the same functionality concurrently, but the issue I had was that i had commits which depended on this pattern. rolling it back and figuring out the differences was a bit of a challenge, which is why i ended up this way.
|
i think just the thank you @jyucsiro |
Adding test case which loads CDL examples in as RDF into rdflib memory store and executes a bunch of SPARQL queries.
Refer to issue #70