9.1 Internal Prefixes #20
Conversation
# Conflicts: # binary-array-ld-cli/src/test/kotlin/net/bald/BinaryArrayConvertCliTest.kt # binary-array-ld-lib/src/main/kotlin/net/bald/model/ModelBinaryArrayBuilder.kt # binary-array-ld-lib/src/test/kotlin/net/bald/model/ModelBinaryArrayBuilderTest.kt # binary-array-ld-lib/src/test/kotlin/net/bald/model/ModelBinaryArrayConverterTest.kt
# Conflicts: # binary-array-ld-cli/src/test/kotlin/net/bald/BinaryArrayConvertCliTest.kt # binary-array-ld-netcdf/src/test/kotlin/net/bald/netcdf/NetCdfBinaryArrayTest.kt
# Conflicts: # binary-array-ld-netcdf/src/test/kotlin/net/bald/netcdf/NetCdfBinaryArrayTest.kt
# Conflicts: # binary-array-ld-cli/src/test/kotlin/net/bald/BinaryArrayConvertCliTest.kt # binary-array-ld-lib/src/main/kotlin/net/bald/model/ModelBinaryArrayBuilder.kt # binary-array-ld-lib/src/main/kotlin/net/bald/vocab/BALD.kt # binary-array-ld-lib/src/test/kotlin/net/bald/model/ModelBinaryArrayBuilderTest.kt # binary-array-ld-lib/src/test/kotlin/net/bald/model/ModelBinaryArrayConverterTest.kt # binary-array-ld-netcdf/src/main/kotlin/net/bald/netcdf/NetCdfBinaryArray.kt # binary-array-ld-netcdf/src/test/kotlin/net/bald/netcdf/NetCdfBinaryArrayTest.kt # binary-array-ld-test/src/main/kotlin/bald/model/ModelVerifier.kt # binary-array-ld-test/src/main/kotlin/bald/netcdf/CdlConverter.kt # binary-array-ld-test/src/main/kotlin/bald/netcdf/NcmlConverter.kt
| val outputFile = createTempFile() | ||
| run("--uri", "http://test.binary-array-ld.net/example", inputFile.absolutePath, outputFile.absolutePath) | ||
|
|
||
| val model = createDefaultModel().read(outputFile.toURI().toString(), "ttl") |
There was a problem hiding this comment.
Might be nice here to share the model verification of run_withPrefixMappingGroup_outputsPrefixMapping() and run_withPrefixMappingVar_outputsPrefixMapping() in a separate function (if possible) to make it clearer that both group and var prefix mapping are expecting the same output?
There was a problem hiding this comment.
Good call, done.
|
Thanks Simon, this looks like it contains the main requirements from the spec for internal prefixes. |
|
I've added the validation for requirement B-2 and B-3. |
|
Thank you very much! Happy with this PR - will merge now |
#9 - Implements internal prefix mappings.
External prefix mappings will be added in a separate branch.
Prefix mappings obtained from the NetCDF file are included in the prefix mappings for the resulting graph but not yet used anywhere (they will be used to parse attribute names and values in a future branch).