Aliases #23

simonoakesepimorphics · 2020-11-24T13:56:13Z

Fixes #12
Support attribute aliasing using alias graphs.

# Conflicts: # binary-array-ld-cli/src/test/kotlin/net/bald/BinaryArrayConvertCliTest.kt # binary-array-ld-lib/src/main/kotlin/net/bald/model/ModelBinaryArrayBuilder.kt # binary-array-ld-lib/src/test/kotlin/net/bald/model/ModelBinaryArrayBuilderTest.kt # binary-array-ld-lib/src/test/kotlin/net/bald/model/ModelBinaryArrayConverterTest.kt

…ternal # Conflicts: # binary-array-ld-lib/src/test/kotlin/net/bald/model/ModelBinaryArrayConverterTest.kt

# Conflicts: # binary-array-ld-cli/src/test/kotlin/net/bald/BinaryArrayConvertCliTest.kt # binary-array-ld-lib/src/main/kotlin/net/bald/model/ModelBinaryArrayBuilder.kt # binary-array-ld-lib/src/main/kotlin/net/bald/vocab/BALD.kt # binary-array-ld-lib/src/test/kotlin/net/bald/model/ModelBinaryArrayBuilderTest.kt # binary-array-ld-lib/src/test/kotlin/net/bald/model/ModelBinaryArrayConverterTest.kt # binary-array-ld-netcdf/src/main/kotlin/net/bald/netcdf/NetCdfBinaryArray.kt # binary-array-ld-netcdf/src/test/kotlin/net/bald/netcdf/NetCdfBinaryArrayTest.kt # binary-array-ld-test/src/main/kotlin/bald/model/ModelVerifier.kt # binary-array-ld-test/src/main/kotlin/bald/netcdf/CdlConverter.kt # binary-array-ld-test/src/main/kotlin/bald/netcdf/NcmlConverter.kt

…ternal

# Conflicts: # binary-array-ld-cli/src/test/kotlin/net/bald/BinaryArrayConvertCliTest.kt # binary-array-ld-lib/src/main/kotlin/net/bald/BinaryArray.kt # binary-array-ld-lib/src/test/kotlin/net/bald/model/ModelBinaryArrayConverterTest.kt # binary-array-ld-netcdf/src/main/kotlin/net/bald/netcdf/NetCdfBinaryArray.kt # binary-array-ld-netcdf/src/main/kotlin/net/bald/netcdf/NetCdfPrefixMappingBuilder.kt # binary-array-ld-netcdf/src/test/kotlin/net/bald/netcdf/NetCdfBinaryArrayTest.kt

# Conflicts: # binary-array-ld-cli/src/test/kotlin/net/bald/BinaryArrayConvertCliTest.kt # binary-array-ld-lib/src/test/kotlin/net/bald/model/ModelBinaryArrayConverterTest.kt

# Conflicts: # binary-array-ld-cli/src/main/kotlin/net/bald/BinaryArrayConvertCli.kt # binary-array-ld-demo/src/main/java/net/bald/NetCdfConvertJava.java

# Conflicts: # binary-array-ld-cli/src/main/kotlin/net/bald/BinaryArrayConvertCli.kt # binary-array-ld-cli/src/test/kotlin/net/bald/BinaryArrayConvertCliTest.kt # binary-array-ld-netcdf/src/test/kotlin/net/bald/netcdf/NetCdfBinaryArrayTest.kt

# Conflicts: # binary-array-ld-cli/src/main/kotlin/net/bald/BinaryArrayConvertCli.kt # binary-array-ld-lib/src/main/kotlin/net/bald/model/ModelVarBuilder.kt

CMayNorris · 2020-11-27T15:56:12Z

Thanks for this Simon. Looks good!
As the code gets larger I think future developers and I, as a reviewer, would benefit from some inline comments regarding which requirements are being met. In particular this would be useful in the test classes and around the model verification. Just a string including the lettered and numbered requirement would help identify the aims of each test or set of tests.
Thank you

CMayNorris · 2020-11-27T16:03:17Z

binary-array-ld-test/src/main/resources/turtle/alias.ttl

+skos:prefLabel a rdf:Property ;
+    dct:identifier "prefLabel" .
+
+bald:Organisation dct:identifier "binary-array-ld-org" .


Could you explain why the bald:Organisation line does not need to include a declaration of ObjectProperty or Property? Is it implied?
Thanks

This is a test case for attribute value aliases, so it is the identifier of a generic resource rather than a property.

simonoakesepimorphics · 2020-12-01T11:30:20Z

Thanks for this Simon. Looks good!
As the code gets larger I think future developers and I, as a reviewer, would benefit from some inline comments regarding which requirements are being met. In particular this would be useful in the test classes and around the model verification. Just a string including the lettered and numbered requirement would help identify the aims of each test or set of tests.
Thank you

I've added some annotations referring to the requirements classes in the places where I think they're relevant. There are also a number of tests which test the "non-normative" part of the spec, which I haven't linked to a specific requirement. We could link those to the document fragments in the draft spec / spec project if appropriate but I don't know how permanent those are.

CMayNorris · 2020-12-03T16:49:39Z

Thanks for adding the requirement references, they are very helpful - Please continue to add these as new tests are added.
Thanks also for the explanation and link to the spec regarding my question.
This all looks good to me, I will approve and merge.
Thanks for all the work!

simonoakesepimorphics added 30 commits October 26, 2020 11:53

Add vocab reference object

35ce80d

Add classes for composing RDF model

cb3f96d

Add RDF model test utils and tests

a064c9b

Add binary array to model conversion API impl

65259bd

Add NetCDF binary array factory method impl, tests

f48cc53

Add CLI impl, test, docs

f8bb029

Fix Java version in maven compiler plugin

0d7420e

Add prefix mapping concept on binary array

e1ec12a

Add prefix mapping to model composition, tests

a712090

Add NetCDF impl of prefix mapping concept

1f1891f

Add tests, upgrade test format to NetCDF4 to support prefix group.

3c5bfec

Add logback config on CLI to suppress debug logs

e14b5c2

NetCDF4 considerations in tests

493a20a

Merge branch 'initial-setup' into feature/8-identity

94f8105

Merge branch 'feature/8-identity' into feature/9.1-prefix-internal

67370a6

Add option to supply external prefixes for NetCDF to model conversion

b699137

Add external prefix / context parameter to CLI, add test

7b1fffc

Update Java example with external prefixes.

6220b94

Rename var

620dfa8

Improve error message wording

c3f7095

Add file container, refactor

65359a2

Add file container to tests

0b35f20

Fix tests

b60b503

Merge branch 'feature/8-identity' into feature/9.1-prefix-internal

a228e28

Merge branch 'feature/9.1-prefix-internal' into feature/9.2-prefix-ex…

f3a6502

…ternal # Conflicts: # binary-array-ld-lib/src/test/kotlin/net/bald/model/ModelBinaryArrayConverterTest.kt

Add NetCDF URI parser class

e2d00ee

Replace BALD PrefixMapping concept with standard Jena PrefixMapping

d15d28e

Add attribute, attribute source concepts

2ea60ee

Add NetCDF implementation of attribute concepts

2fdc368

simonoakesepimorphics added 21 commits November 5, 2020 10:02

Fix merge issue

87bc8aa

Use common test method

ade7db8

Add prefix mapping validation

6acdf90

Merge branch 'feature/9.1-prefix-internal' into feature/9.2-prefix-ex…

9a7214c

…ternal

Refactor the RDF context impl as a decorator

4a0ee2e

Add prefix conflict validation

9e33f03

Fix reduce on empty list

901d80f

Restore closeable interface

6795240

Merge branch 'feature/9.2-prefix-external' into feature/10-attributes

d438f49

# Conflicts: # binary-array-ld-cli/src/test/kotlin/net/bald/BinaryArrayConvertCliTest.kt # binary-array-ld-lib/src/test/kotlin/net/bald/model/ModelBinaryArrayConverterTest.kt

Merge branch 'feature/10-attributes' into feature/12-aliases

a646610

# Conflicts: # binary-array-ld-cli/src/main/kotlin/net/bald/BinaryArrayConvertCli.kt # binary-array-ld-demo/src/main/java/net/bald/NetCdfConvertJava.java

Add extension function for URI composition

9d0d8a1

Fix tests

49a3ef1

Tidy up

0473ab7

Merge branch 'feature/10-attributes' into feature/12-aliases

00062f7

# Conflicts: # binary-array-ld-cli/src/main/kotlin/net/bald/BinaryArrayConvertCli.kt # binary-array-ld-lib/src/main/kotlin/net/bald/model/ModelVarBuilder.kt

Merge branch 'master' into feature/10-attributes

5ca80b4

Merge branch 'feature/10-attributes' into feature/12-aliases

1b598e0

Alias definition interface change

8db55e8

Support multiple alias graphs

ab8a8a0

simonoakesepimorphics requested a review from CMayNorris November 24, 2020 13:56

CMayNorris reviewed Nov 27, 2020

View reviewed changes

simonoakesepimorphics added 2 commits December 1, 2020 11:10

Reference requirements in tests

3cc08cf

Requirements refs

7ac8b56

CMayNorris merged commit 9c4d7ad into binary-array-ld:master Dec 3, 2020

simonoakesepimorphics deleted the feature/12-aliases branch April 28, 2021 14:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Aliases #23

Aliases #23

Uh oh!

simonoakesepimorphics commented Nov 24, 2020

Uh oh!

CMayNorris commented Nov 27, 2020

Uh oh!

CMayNorris Nov 27, 2020 •

edited

Loading

Uh oh!

simonoakesepimorphics Nov 30, 2020

Uh oh!

simonoakesepimorphics commented Dec 1, 2020

Uh oh!

CMayNorris commented Dec 3, 2020

Uh oh!

Uh oh!

Aliases #23

Aliases #23

Uh oh!

Conversation

simonoakesepimorphics commented Nov 24, 2020

Uh oh!

CMayNorris commented Nov 27, 2020

Uh oh!

CMayNorris Nov 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

simonoakesepimorphics Nov 30, 2020

Choose a reason for hiding this comment

Uh oh!

simonoakesepimorphics commented Dec 1, 2020

Uh oh!

CMayNorris commented Dec 3, 2020

Uh oh!

Uh oh!

CMayNorris Nov 27, 2020 •

edited

Loading