Skip to content

Var to var references - reshape #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 1, 2021
Merged

Var to var references - reshape #32

merged 5 commits into from
Jun 1, 2021

Conversation

simonoakesepimorphics
Copy link
Collaborator

Fixes #31
Implements the spec changes from opengeospatial/netcdf-ld#76.

  • Infer references from variable to variable relationships (ModelReferenceBuilder).
  • Replaced coordinate property on Dimension with generalised references list on Var.
  • Changed some lists to sequences for optimisation.

CMayNorris
CMayNorris approved these changes May 28, 2021
View reviewed changes
Copy link
Collaborator

@CMayNorris CMayNorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay,
Thank you Simon, this looks good to me. Will merge

@CMayNorris CMayNorris merged commit 1039197 into binary-array-ld:master Jun 1, 2021
@simonoakesepimorphics simonoakesepimorphics deleted the feature/14-reshape branch June 1, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CMayNorris CMayNorris CMayNorris approved these changes

@marqh marqh Awaiting requested review from marqh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variable reference shapes
2 participants
@simonoakesepimorphics @CMayNorris