This repository was archived by the owner on Feb 22, 2024. It is now read-only.
kelly/tourdropdown #111
Merged
kelly/tourdropdown #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminmarashi
reviewed
Dec 29, 2016
src/botPage/view/index.js
Outdated
| if ($('#select-tour').css('display') === 'block') { | ||
| $('#select-tour') | ||
| .fadeOut(100) | ||
| } |
There was a problem hiding this comment.
Has trailing space, please remove. Better to run npm test to make sure.
aminmarashi
reviewed
Dec 29, 2016
src/botPage/view/index.js
Outdated
| }) | ||
|
|
||
| $('body') | ||
| .click(e => { |
There was a problem hiding this comment.
e is defined but not used, please replace with:
.click(() => {
aminmarashi
reviewed
Dec 29, 2016
| } | ||
|
|
||
| .tours { | ||
| position: relative; |
|
Merged, opened this issue to fix the topbar positioning: #114 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated 'Select a Tour' dropdown