dev to beta #1306

ashkanx · 2019-03-07T11:16:45Z

Q	A
Fixed Issues?	`Fixes #1, Fixes #2`
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Does not reduce coverage?	Yes
Any Dependency Changes?

…rs + prediction from API, refactoring

…ed on contracts_for response

…be found

…symbol-change

…iredData() checks

…te combo

…locks

From constants to API

coveralls · 2019-03-07T11:21:29Z

Coverage decreased (-2.2%) to 71.799% when pulling 12c0f42 on dev into 2dcaf4d on beta.

Aaron Imming added 30 commits February 27, 2019 16:35

Clean up unused constants

89b0c5a

Filter n/a (sub)markets & symbols, implement logic for getting barrie…

0bcbe2a

…rs + prediction from API, refactoring

Always initialise barrier offset + prediction fields

5c0fc94

Create common function for generating barriers, hide fields by default

9eb50e1

Combine getTradeType & getSelectedSymbol into common function

885b171

Move custom functions to customBlockly, add attachShadowBlock function

b8c3889

Remove custom blockly hooks, move them to customBlockly

1dbe490

Create hideInteractionsFromBlockly function

eb875ad

Refactor tradeOptions, show barrier offset, prediction, durations bas…

4285efb

…ed on contracts_for response

package-lock.json

078c3aa

Default to smallest barriers if barriers based on duration could not …

9d5039b

…be found

Maintain user-imported duration, but default to smallest duration on …

9e860b6

…symbol-change

Add args to only change min duration in updateDurationLists args

2260532

Remove default duration value

07fa8fc

Add eslint exception

e89288e

Small refactor

5bd5659

Default to smallest durations when changing tradeType

3d61458

Don't let haveContractForSymbol bypass isDifferentAccount() and isExp…

0d3c321

…iredData() checks

Only get updated data if not already doing so

abd1e43

Lock call to getContractsForSymbolFromApi

23945c9

Suppress incorrect error

38335d0

One-time events don't work

ca5236a

Maintain duration unit when changing tradeType

4f70173

Disable frxUSDSEK as we don't offer forward-starting contracts

2188a8b

Add absoluteBarrier

de86a46

Refactor tradeOptionToProposal() and add absoluteBarrier prop

923cd4e

Set barrier equal to contracts.barrier (req for day-durations)

4413754

Add absoluteBarrier() block generator function

8db78cf

Create logic to determine ABSOLUTEBARRIER vs (SECOND)BARRIEROFFSET

f87af5e

Create secondAbsoluteBarrier

a49c17a

Aaron Imming and others added 28 commits February 27, 2019 16:35

Return API values rather than calculating the barrier value

5b98cd9

Typo

dc66d16

Remove unused labels var

5ad9480

Fix test

882615a

Merge branch 'dev' into from-constants-to-api

8d66dbb

Remove absoluteBarriers

b837494

Prefix barrier types, remove absoluteBarrier related

5534e6c

Remove references to absoluteBarriers

ac091a5

Create logic for allowing absolute barriers

9b021bf

Remove absoluteBarriers

729cb2c

Update barrierOffsetGenerator, remove absoluteBarrierGenerator

cc08325

Refactor barrier logic to accomodate absolute barriers

1ed1905

Do not pass barrier returned by 'reset' barrier_category

c7ccae3

Change barrier labels based on barrier number + type, add handlebars

f8cf410

Remove duplicate declaration

b542135

Allow same offset types to be set, but don't allow both offset/absolu…

092f1fe

…te combo

Refactor logic for getting barrier values

fa92ffb

Move handlebar logic to its own function, refactor barrier logic

95810ce

Maintain values on moving tradeOptions back into trade if possible

c81578c

Check barrier types on tradeType change

984e4a3

Fixes

ebbc457

Support barrier handlebars for multiple and individual tradeOptions b…

01827d4

…locks

Send absolute barrier as string

ebedb9f

Keep bot running on ContractValidationError

7f9fb46

Fix eslint errors

73f84e8

Check if contract is available

cb821ba

Merge branch 'dev' into from-constants-to-api

4600e30

Merge pull request #1247 from aaron-binary/from-constants-to-api

12c0f42

From constants to API

ashkanx merged commit 4876515 into beta Mar 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

dev to beta #1306

dev to beta #1306

Uh oh!

ashkanx commented Mar 7, 2019

Uh oh!

coveralls commented Mar 7, 2019

Uh oh!

Uh oh!

dev to beta #1306

dev to beta #1306

Uh oh!

Conversation

ashkanx commented Mar 7, 2019

Uh oh!

coveralls commented Mar 7, 2019

Uh oh!

Uh oh!