Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

Conversation

khalidibrahimio
Copy link
Contributor

@khalidibrahimio khalidibrahimio commented Apr 4, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Does not reduce coverage? Yes
Any Dependency Changes? No

The button in the index page is not responsive with all languages. So, a little extra padding was added to fix an issue where the button sticks to the image for some languages.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 71.735% when pulling 9e016fb on Khalidxx:language-responsive into 200a41d on binary-com:dev.

display: flex;
flex-direction: row;
width: 100%;
.puzzle-logo {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, can add new line here before .puzzle-logo

@ashkanx ashkanx merged commit 4d56108 into binary-com:dev Apr 5, 2019
@khalidibrahimio khalidibrahimio deleted the language-responsive branch April 5, 2019 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants