This repository was archived by the owner on Feb 22, 2024. It is now read-only.
Pass visitorId to GTM #1438
Merged
Pass visitorId to GTM #1438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashkanx
reviewed
Apr 22, 2019
| const setVisitorId = () => { | ||
| const tokenList = getTokenList(); | ||
| if (tokenList.length > 0) { | ||
| pushDataLayer({ visitorId: tokenList[0].loginInfo.loginid }); |
There was a problem hiding this comment.
what if the client switched the account from the dropdown?
There was a problem hiding this comment.
what if the client switched the account from the dropdown?
The token list in local storage reflects the same order as can be seen in the dropdown, so the 0 index will always be the account that's active. The setVisitorId function is called on both account switch & logout, so it would pass the correct visitorId to the data layer.
ashkanx
reviewed
Apr 22, 2019
| if (tokenList.length > 0) { | ||
| pushDataLayer({ visitorId: tokenList[0].loginInfo.loginid }); | ||
| } else { | ||
| pushDataLayer({ visitorId: undefined }); |
There was a problem hiding this comment.
I'm not sure if pushing undefined is necessary
There was a problem hiding this comment.
If a user logs out and visitorId isn't set to undefined, it would still register clicks as the most previous logged in user.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.