heikin-ashi candle list

[anton-binary]

No description provided.

[coveralls]

Coverage remained the same at 70.024% when pulling 46fa0bd on anton-binary:heikin-ashi-example-xml into dd5f8e3 on binary-com:dev.

[hotmatrixx]

Hi buddy.
I developed an Heiken ashi bot a while back, seeing as you didn't have an indicator with this function. So I was excited when I saw that you're intergrating the HA indicator into binary.com or deriv.com.

Of course I was interested to see how you approached the problem, but I've seen a couple of things with your code, I'm sorry;

1st; i don't claim to be perfect; and i only partially understand how the return;type function works. if i'm wrong, then that's fine and i'm happy to shut up, but if I'm correct you'd be sending everyone the wrong signals to use for their indicators.

1. You're HA (hi/low) calculations are incorrect; they are defined as the high of the set (high, HAopen HAclose) and low for the the set ( Low HAopen HAclose) of the previous candle. NOT the high of the previous candle as sometimes the HA values are vastly different to the previous candle's. Trust me I've actually used that and it can throw the candles out by quite a lot in fringe cases.

2. something seems off abou that loop counter; I can't quite see what it is as it's not quite doing what I think you expect it to, and TBH it's messy how it inserts stuff all over the place and uses itself as a reference point. I don't quite understand the logic for som reason, maybe I need more coffee.

3; it looks like you're makeing a nested array? I didn't realise that was possible, so the function is returning a nested list with around 4000 values in it?

4 inside that loop you calculate the new open and close for each candle in (i), but not the unique high and low - instead you use those values which were calculated outside, and just prior to the loop, so you have 1000 sets of data with the candles, but they all return the same hi/low values, yet when I look inside the csv this generates they do all have differing values, which goes to show I don't understand quite what's happening here. Each cell contains too many data sets. I don't get how that's all generated. Clearly I don't understand this function well enough.

5. I'll attach a screenshot of the method I'm using (looking at your code made me spot a bug in mine that I've corrected, so that's great.). I didn't know abou tthe "average" function, so I did the math the 'long' way - which actually makes for nice, neat lines that all help it to fit in a single screenshot for you, so that's convenient. Maybe some of it's useful to you? I was literally just going over it to release it for the users now, anyway. I actually feel that my code might be more conscise and simpler to follow/debug, too

Adding it into a function and adding a loop counter would be super simple.

Like I said, there are bits that I don't understand, like the nested list values, and how a new high/low are generated on each loop when there is no calculation made for them in the loop - it's almost like one of the lists is saved as a string that's recalculating on every iteration.
I need more coffee.

IF IF IF you were able or willing to take the time to break your logic down in order to help my understand these functions - the last and most complicated part of the bot that I don't understand - it could help me IMMENSELY.

Additionally, I am going to start making a tutorial series on using every aspect of the bot, so if I understand it I can help everyone else to, as well. I'm thinking that I might do it using deriv.com as that's goign to be the platform in the future - can you give me some advice on whether I should use binary.com or deriv.com for this?

Hopefully you find something useful in all of this;
Thank you again for building this beast; there is literally nothing like it anywhere else.