-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Transit EDN in Network Panel's request preview #37
Comments
This would be great! |
@darwin I just copied here a reformatted version of what you wrote on Slack to preserve it: Just briefly looked at the devtools sources, web socket data frames and normal network request previews are handled differently. dirac/resources/unpacked/devtools/front_end/network/ResourceWebSocketFrameView.js Lines 179 to 197 in cff8e6c
Actually if JSON view cannot be provided, it falls back to dirac/resources/unpacked/devtools/front_end/network/RequestResponseView.js Lines 75 to 91 in cff8e6c
We would have to implement a new SourceFrame.ResourceSourceFrame type and detect packed transit there.
|
To add a suggestion - maybe it would be worth it to not detect anything but rather to allow users to select what the actual mime type is. Although I'm not sure it that would be possible via the UI, but I'm perfectly fine with having to specify a config option for it. Especially if it would support any custom type (e.g. transit allows extensions - no level of detection could handle that). |
Similar to JSON display.
The text was updated successfully, but these errors were encountered: