Deprecation of save(false) for save(:validate => false) (Rails3)

[rab]

DEPRECATION WARNING: save(false) is deprecated, please give save(:validate => false) instead. (called from save at /Users/rab/.rvm/gems/ruby-1.9.2-r28283/gems/activerecord-3.0.0.rc/lib/active_record/validations.rb:43)

Digging in the call stack, the source of the save is in
authlogic-2.1.5/lib/authlogic/session/callbacks.rb at line 95
http://github.com/binarylogic/authlogic/blob/master/lib/authlogic/session/callbacks.rb#L95

The corrected call should replace false with :validate => false

    def save_record(alternate_record = nil)
      r = alternate_record || record
      r.save_without_session_maintenance(:validate => false) if r && r.changed? && !r.readonly?
    end

[rab]

forked and created a pull request for this fix and another in acts_as_authentic/logged_in_status.rb:35+36 named_scope => scope

[h0jeZvgoxFepBQ2C]

Could you apply that patch? thx

The warning is nasty..

[MikieC]

Here are all the places where false is getting passed down to save:

./authlogic/session/callbacks.rb:95: r.save_without_session_maintenance(false) if r && r.changed? && !r.readonly?

./authlogic/acts_as_authentic/password.rb:280: save_without_session_maintenance(false)

./authlogic/acts_as_authentic/password.rb:317: save(false)

./authlogic/acts_as_authentic/persistence_token.rb:56: save_without_session_maintenance(false)

./authlogic/acts_as_authentic/perishable_token.rb:94: save_without_session_maintenance(false)

[dmonopoly]

wait - so what exactly should be done so we can avoid this error?

[h0jeZvgoxFepBQ2C]

# This is deprecated
save(false)  

# change all "save(false)" occurences to   
save(:validate => false)

[dmonopoly]

was this going to be patched up?
should I go in the gems and change all this, or just wait? :O

[herrtreas]

+1

[gtd]

+1

[jsl]

Please apply this patch

[h0jeZvgoxFepBQ2C]

Added pull request

http://github.com/binarylogic/authlogic/issues#issue/169

[m3talsmith]

This is so annoying! Please pull the patch!

[h0jeZvgoxFepBQ2C]

This pull request breaks rails 2 compability...

[m3talsmith]

Then remove the depreciation warning

[h0jeZvgoxFepBQ2C]

The deprecationwarning comes from rails itself..

[m3talsmith]

ok.