Fix PEM format private key and certificate handling in WeChat Pay config #3712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
loadConfigInputStream
method inWxPayConfig
was incorrectly applying Base64 decoding to all string inputs, causing failures when users provided PEM format private keys or certificates viasetPrivateKeyString()
orsetPrivateCertString()
.Problem
When users called:
The SDK would throw
WxRuntimeException: 无效的密钥格式
(Invalid Key Format) because:loadConfigInputStream
always applied Base64 decoding to string inputs-----BEGIN PRIVATE KEY-----
) with characters that are invalid in Base64IllegalArgumentException: Illegal base64 character 2d
(hyphen character)PemUtils.loadPrivateKey()
Solution
Added intelligent format detection to distinguish between:
-----BEGIN
and-----END
markers): Pass through as UTF-8 bytes forPemUtils
to handleChanges
loadConfigInputStream
method with smart format detectionStandardCharsets
import for proper UTF-8 encodingTesting
The fix handles all scenarios correctly:
This resolves WeChat Pay v3 API initialization failures in JDK 21 environments while preserving compatibility with existing implementations.
Fixes #3680.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.