Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support provider: github #17

Closed
wilsonehusin opened this issue Mar 18, 2022 · 3 comments · Fixed by #56
Closed

Support provider: github #17

wilsonehusin opened this issue Mar 18, 2022 · 3 comments · Fixed by #56
Labels
enhancement New feature or request ux Ensures a good time when using the product
Milestone

Comments

@wilsonehusin
Copy link
Member

wilsonehusin commented Mar 18, 2022

Currently, programs need to specify complete URL template.

This is helpful to support all sources. However, most programs come from GitHub releases. Would be nice to have something simplified and auto-detect the common pattern (or lookup from GitHub API), such that the config manifest can look simpler like:

name: myprogram
version: 0.1.0
provider: github
path: myorg/myprogram
overlay:
  Host: https://mygithubenterprise.com  # optional, defaults to "https://github.com"

While the lockfile manifest should remain the same.

(Or at least I don't think there is a need to change it)

@wilsonehusin wilsonehusin added enhancement New feature or request ux Ensures a good time when using the product labels Mar 18, 2022
@wilsonehusin
Copy link
Member Author

wilsonehusin commented Mar 18, 2022

Maybe we should do this in baby steps — I think I would be quite happy to have something like this:

name: myprogram
version: 0.1.0
provider: github
path: myorg/myprogram/_/.tar.gz

Which would generate the URL:

https://github.com/myorg/myprogram/releases/download/v0.1.0/myprogram_0.1.0_Linux_arm64.tar.gz

Alternatively, shove them all in overlay section:

name: myprogram
version: 0.1.0
provider: github
path: myorg/myprogram
overlay:
  Host: "github.com"
  Tag: "v{{ .Version }}"
  Separator: "_"
  Ext: ".tar.gz"
  ArchiveNameVersion: "{{ .Version }}"

@wilsonehusin wilsonehusin added the brainstorm Not yet implementable (e.g. design phase or blocked) label Mar 18, 2022
@wilsonehusin wilsonehusin added this to the v0.1.0 milestone Mar 30, 2022
@wilsonehusin
Copy link
Member Author

Relevant-ish: #35

@wilsonehusin
Copy link
Member Author

The structure of program configuration was re-done in #54, which now should make it closer to the comment above.

@wilsonehusin wilsonehusin removed the brainstorm Not yet implementable (e.g. design phase or blocked) label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux Ensures a good time when using the product
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant