This repository has been archived by the owner on Jun 26, 2024. It is now read-only.
✨ Implement cosign verification #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add --bootstrap flag for bindl get to bootstrap cosign
Functional test (program/cosign_test.go) requires cosign binary to exist as it would not be able to bootstrap cosign through test binary. This can be eliminated if we don't shell out to run cosign bootstrap, but it requires solving dependency tree which would otherwise cause a dependency loop between command/ and program/, _sigh_.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it
Implement cosign verification (i.e.
cosign verify-blob) forchecksums.txt.Upon implementation and discovery, I found that implementing verification to
checksums.txtseems to be the most practical as opposed to allowing multiple mechanisms of verification (by default, Goreleaser also signs only checksum file).We should make it easy for people to verify signature by themselves though. Since the data of certificate and signature is already stored in the lockfile anyway, I think we should do something like
bindl exportfor the metadata in lockfile (tracked #55).Which issue(s) this PR fixes
Fixes #15