fix(pwa): hide install prompt on macOS 14 safari #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS 17 does indeed play sounds.
nihalgonsalves
force-pushed
the
ng/fix-safari-17-sonoma
branch
from
e41df66
to
d33eded
Compare
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #899 +/- ##
==========================================
- Coverage 65.80% 65.77% -0.03%
==========================================
Files 53 53
Lines 7697 7697
==========================================
- Hits 5065 5063 -2
- Misses 1790 1791 +1
- Partials 842 843 +1 ☔ View full report in Codecov by Sentry. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS 14 has support for "Add to Dock", which added the
window.navigator.standaloneproperty to macOS. This was previously only on iOS and we relied on it to display the "install required" prompt.Since the limitation of needing an installed web app does not exist on desktop Safari, ntfy therefore wrongly stops you from using the web app notifications. This changes the heuristic to only display the install prompt when the push manager API is not available.
I also added a screenshot of the new Safari "Add to Dock" action to the docs.
While testing it I saw a deprecation warning when using the node source script, so I fixed that too - I can move that to another PR if wanted.