-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support to run build for recipes with linux-aarch64 additional-platforms #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
martin-g
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yikun
changed the title
feat: add support to run build for recipes with additional-platforms
feat: add support to run build for recipes with linux-aarch64 additional-platforms
Oct 9, 2023
johanneskoester
requested changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks! Would you mind adding a test case?
Yikun
force-pushed
the
addition
branch
2 times, most recently
from
October 13, 2023 07:57
2f9dfb5
to
5e23104
Compare
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
johanneskoester
requested changes
Oct 13, 2023
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
johanneskoester
approved these changes
Oct 14, 2023
johanneskoester
pushed a commit
that referenced
this pull request
Oct 14, 2023
🤖 I have created a release \*beep\* \*boop\* --- ## [2.7.0](https://www.github.com/bioconda/bioconda-utils/compare/v2.6.0...v2.7.0) (2023-10-14) ### Features * add support to run build for recipes with linux-aarch64 additional-platforms ([#923](https://www.github.com/bioconda/bioconda-utils/issues/923)) ([55671f7](https://www.github.com/bioconda/bioconda-utils/commit/55671f77124065fd09bb7d9c4a856cf0e87e48a4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches add support in bioconda-utils to run on linux-arm if the following is added to the recipe:
check_native_platform_skippable
to checkout should we skip the recipes in current nativei platformextra_additional_platforms
property to recipe objectfetch-depth
related: bioconda/bioconda-recipes#40550