Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to run build for recipes with linux-aarch64 additional-platforms #923

Merged
merged 5 commits into from
Oct 14, 2023

Conversation

Yikun
Copy link
Contributor

@Yikun Yikun commented Oct 9, 2023

This patches add support in bioconda-utils to run on linux-arm if the following is added to the recipe:

extra:
  additional-platforms:
    - linux-aarch64
  • Add a check_native_platform_skippable to checkout should we skip the recipes in current nativei platform
  • Add extra_additional_platforms property to recipe object
  • Add UT to test above function
py.test --durations=0 test/test_utils.py::test_native_platform_skipping
py.test --durations=0 test/test_recipe.py::test_recipe_extra_additional_platforms
  • E2E test
bioconda-utils build recipes config.yml --git-range origin/master HEAD
bioconda-utils build recipes config.yml --git-range origin/master HEAD --force
  • Fix test trigger by adding fetch-depth

related: bioconda/bioconda-recipes#40550

Copy link
Contributor

@martin-g martin-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yikun Yikun changed the title feat: add support to run build for recipes with additional-platforms feat: add support to run build for recipes with linux-aarch64 additional-platforms Oct 9, 2023
Copy link
Contributor

@johanneskoester johanneskoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! Would you mind adding a test case?

@Yikun Yikun force-pushed the addition branch 2 times, most recently from 2f9dfb5 to 5e23104 Compare October 13, 2023 07:57
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
bioconda_utils/build.py Outdated Show resolved Hide resolved
bioconda_utils/build.py Outdated Show resolved Hide resolved
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@johanneskoester johanneskoester merged commit 55671f7 into bioconda:master Oct 14, 2023
9 checks passed
johanneskoester pushed a commit that referenced this pull request Oct 14, 2023
🤖 I have created a release \*beep\* \*boop\*
---
##
[2.7.0](https://www.github.com/bioconda/bioconda-utils/compare/v2.6.0...v2.7.0)
(2023-10-14)


### Features

* add support to run build for recipes with linux-aarch64
additional-platforms
([#923](https://www.github.com/bioconda/bioconda-utils/issues/923))
([55671f7](https://www.github.com/bioconda/bioconda-utils/commit/55671f77124065fd09bb7d9c4a856cf0e87e48a4))
---


This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants