BUG: Fix issue #271 #291
Merged
BUG: Fix issue #271 #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a category in the mapping file had a unique/single valued column, this would automatically be removed regardless of the fact that the user could have asked to keep the column. Some tests were fixed to reflect the case they were checking. Fixes biocore#271
|
The test build for this pull request can be found here: http://emperor.colorado.edu/pull_291/make_emperor/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unique/single-valued columns were removed from the mapping file even if these
were selected with the --color_by option. I've added a few test cases to check
for this.
Fixes #271