Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tensor building #15

Merged
merged 3 commits into from
Jun 13, 2019
Merged

Update tensor building #15

merged 3 commits into from
Jun 13, 2019

Conversation

cameronmartino
Copy link
Collaborator

No description provided.

gwarmstrong
gwarmstrong reviewed Jun 13, 2019
View reviewed changes
README.md Show resolved Hide resolved
gwarmstrong
gwarmstrong reviewed Jun 13, 2019
View reviewed changes
Copy link
Member

@gwarmstrong gwarmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few general comments in the diff, regarding clarity and testing practices. Otherwise looks good to me.

@gwarmstrong gwarmstrong self-requested a review June 13, 2019 17:28
gwarmstrong
gwarmstrong approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@gwarmstrong gwarmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready to merge.

@cameronmartino cameronmartino merged commit 770b7f0 into master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwarmstrong gwarmstrong gwarmstrong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cameronmartino @gwarmstrong