Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache #64

Merged
merged 13 commits into from
Mar 15, 2016
Merged

Cache #64

merged 13 commits into from
Mar 15, 2016

Conversation

mortonjt
Copy link
Collaborator

No description provided.

pandas.DataFrame
The best matched records for each query sequence.
'''
seqs = list(read(diamond_res, format='sam'))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it be iterator instead of materialized list?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@mortonjt
Copy link
Collaborator Author

Fixed most of the stylistic changes. However, this will fail, because it is importing sam.

BUT - sam is actually required for the parsers to work. Not sure how to get travis to ignore this.

@RNAer
Copy link
Collaborator

RNAer commented Mar 15, 2016

you have to import it globally to make it work. see embl as an example:
https://github.com/biocore/micronota/blob/master/micronota/__init__.py

On Tue, Mar 15, 2016 at 10:21 AM, Jamie Morton notifications@github.com
wrote:

Fixed most of the stylistic changes. However, this will fail, because it
is importing sam.

BUT - sam is actually required for the parsers to work. Not sure how to
get travis to ignore this.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#64 (comment)

@mortonjt
Copy link
Collaborator Author

🎆 tests passing. Ready for review.

RNAer added a commit that referenced this pull request Mar 15, 2016
@RNAer RNAer merged commit 951e032 into biocore:master Mar 15, 2016
@mortonjt
Copy link
Collaborator Author

Thanks!

On Tue, Mar 15, 2016 at 1:19 PM, Zech Xu notifications@github.com wrote:

Merged #64 #64.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#64 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants