WIP Split sirius #46
Merged
WIP Split sirius #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 54
💛 - Coveralls |
ElDeveloper
approved these changes
Dec 10, 2018
There was a problem hiding this comment.
Looks ready to be merged, just a couple of minor comments. Thanks @anupriyatripathi!
q2_chemistree/_fingerprint.py
Outdated
| if java_flags is not None: | ||
| # append the flags to any existing options | ||
| os.environ['_JAVA_OPTIONS'] = initial_flags + ' ' + java_flags | ||
| print(os.listdir(os.path.dirname(artifact.get_path()))) |
q2_chemistree/_fingerprint.py
Outdated
| number of fragmentation trees to compute per feature | ||
| database: str | ||
| search formulas in given database | ||
| profile: str |
There was a problem hiding this comment.
Would you might moving this line to be underneath ppm_max.
| def get_folder_name(self): | ||
| return 'base-output' | ||
|
|
||
| def get_path(self): |
There was a problem hiding this comment.
Can you add a short description to this method: Get the path to the directory where the outputs are saved.
|
Thanks @anupriyatripathi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow splitting each processing step in Sirius to generate fingerprints. Fixes #33