Fix some opposite predicates should be inverses #1179
Conversation
| @@ -1678,8 +1678,6 @@ slots: | |||
| - OMIM:has_manifestation | |||
| - SNOMED:has_basic_dose_form | |||
| - UMLS:RB | |||
| annotations: | |||
| opposite_of: subclass of | |||
There was a problem hiding this comment.
I think subclass of is the opposite of superclass of -- the inverse here would be has superclass but I do see the issue here, where we declare it both the inverse and the opposite. Will fix.
There was a problem hiding this comment.
Isn't has superclass just another way to say subclass of? I agree with @vincentvialard that this is an inverse situation, not opposite.
There was a problem hiding this comment.
I think has superclass and superclass of are basically saying the same thing but in inverse directions.
There was a problem hiding this comment.
Yes but has superclass and subclass of are just synonyms of each other.
There was a problem hiding this comment.
practically, I agree with you; in biolink, they are two distinct predicates?
There was a problem hiding this comment.
I don't see has superclass in the model; I think I'm just introducing confusion here. :-)
There was a problem hiding this comment.
after talking a little more with Jim and the Biolink team today, we'll remove the opposite designation from subclass_of and superclass_of, as well as the inverse.
vincentvialard
deleted the
fix-some-opposite-predicates-should-be-inverses
branch
No description provided.