This repository has been archived by the owner on Oct 2, 2021. It is now read-only.
Issue 320 mixin abstract as default #321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 17, 2020 08:00
…ls conflict with latest BIolink Model clinical models
|
Got caught with PR 323 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested patch for issue #320 which was inspired by Biolink Model issue biolink/biolink-model#540. All relevant tests pass.
Everywhere the boolean truth value of
cls.abstractis tested, the boolean truth value ofcls.mixinis now also tested thus drives model behavior accordingly.The one practical semantic difference remains(?) that
abstractclasses can only be present once in the schema within a single class hierarchy, whereas references tomixindefinitions are defined in their own class hierarchy but may be injected multiple times into the regular class and slot hierarchies, as a values of themixinsproperty of a target class (or slot). The practical refinement ofmixinbehavior remains to be refined (in other code revisions hence PR's).