Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lint/useImportType): handle multiline statements #2045

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

Conaclos
Copy link
Member

Summary

Fix #2041

Code fixes of useImportType and useExportType now handle multiline statements.

Test Plan

I added non-regression tests.

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for biomejs canceled.

Name Link
🔨 Latest commit c809fcb
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65eef6751a7e6100080dd8a2

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Mar 11, 2024
@Conaclos Conaclos force-pushed the conaclos/2041 branch 2 times, most recently from 5e56e9b to c809fcb Compare March 11, 2024 12:17
@github-actions github-actions bot added the A-Tooling Area: internal tools label Mar 11, 2024
@Conaclos Conaclos merged commit 461a5be into main Mar 11, 2024
7 checks passed
@Conaclos Conaclos deleted the conaclos/2041 branch March 11, 2024 12:18
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 593 593 0
Failed 69 69 0
Panics 0 0 0
Coverage 89.58% 89.58% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13439 13439 0
Failed 4205 4205 0
Panics 2 2 0
Coverage 76.16% 76.16% 0.00%

Copy link

codspeed-hq bot commented Mar 11, 2024

CodSpeed Performance Report

Merging #2045 will improve performances by 12.65%

⚠️ No base runs were found

Falling back to comparing conaclos/2041 (c809fcb) with main (ffc349c)

Summary

⚡ 2 improvements
✅ 91 untouched benchmarks

Benchmarks breakdown

Benchmark main conaclos/2041 Change
db.json[cached] 78 ms 73.5 ms +6.12%
db.json[uncached] 92.7 ms 82.3 ms +12.65%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Tooling Area: internal tools A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lint/useImportType and lint/useExportType code fixes wrongly handle multiline statements
1 participant