fix(formatter): don't let overrides erroneously enable formatter if unspecified #2957
+128
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, overrides could erroneously enable the formatter if it was supposed to be disabled, specifically in configurations like this:
This PR fixes that behavior by not forcing the override settings to have a
Some
value no matter what. I briefly looked into whether or not this affects the linter too, and I think it does, but I think that fix is outside the scope of this PR. This area of the code is likely going to be significantly changed by work on #2228. It's somewhat unclear what the semantics of overrides should be (if 2 overrides match the same file, do they get merged? do we take the first matching override and ignore the rest? the last one? etc etc)Fixes #2924
Test Plan
Added a test with snapshots