Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(noEvolvingAny): rename into noEvolvingTypes #2959

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented May 23, 2024

Summary

Fix biomejs/website#48 by;

  • Renaming the rule into noEvolvingTypes
  • Updating the rule description

Test Plan

I updated the snapshots.

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis A-Changelog Area: changelog labels May 23, 2024
@Conaclos Conaclos requested a review from a team May 23, 2024 16:44
Copy link

codspeed-hq bot commented May 23, 2024

CodSpeed Performance Report

Merging #2959 will not alter performance

Comparing conaclos/no-evolving-types (2107cd0) with main (dad0fcb)

Summary

✅ 92 untouched benchmarks

@unvalley unvalley changed the title refactor(noEvolvingny): rename into noEvolvingTypes refactor(noEvolvingAny): rename into noEvolvingTypes May 23, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just left a question about a change that seem unrelated

@Conaclos Conaclos force-pushed the conaclos/no-evolving-types branch 2 times, most recently from 76a3919 to 132b97d Compare May 24, 2024 15:25
@Conaclos Conaclos force-pushed the conaclos/no-evolving-types branch 2 times, most recently from 4effb33 to 2107cd0 Compare June 3, 2024 19:54
@Conaclos Conaclos merged commit 44b5c29 into main Jun 3, 2024
14 checks passed
@Conaclos Conaclos deleted the conaclos/no-evolving-types branch June 3, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📚 New no-evolving-any rule documentation lacks proper examples and/or references
3 participants