Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lint/noUndeclaredVariables): don't alert on arguments object in a function scope #2964

Merged
merged 5 commits into from
May 24, 2024
Merged

fix(lint/noUndeclaredVariables): don't alert on arguments object in a function scope #2964

merged 5 commits into from
May 24, 2024

Conversation

ah-yu
Copy link
Contributor

@ah-yu ah-yu commented May 24, 2024

Summary

Test Plan

Add new tests and update snapshots

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels May 24, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 24, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2964 will not alter performance

Comparing ah-yu:fix/no_undeclare (077759d) with main (af70ac2)

Summary

✅ 92 untouched benchmarks

@github-actions github-actions bot added the A-CLI Area: CLI label May 24, 2024
@ah-yu ah-yu merged commit c3c5308 into biomejs:main May 24, 2024
12 checks passed
@ah-yu ah-yu deleted the fix/no_undeclare branch May 24, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conaclos Conaclos Conaclos left review comments

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive in noUndeclaredVariables
3 participants
@ah-yu @ematipico @Conaclos