Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime dispatch with ft_fix_before #29

Closed
roflmaostc opened this issue Nov 22, 2022 · 4 comments
Closed

Runtime dispatch with ft_fix_before #29

roflmaostc opened this issue Nov 22, 2022 · 4 comments

Comments

@roflmaostc
Copy link
Member

Hi,

@RainerHeintzmann there is a couple of runtime dispatches because of type-instability.

See this:

mat = FourierJoin(mat, d, L1)

I think you probably should always return the FourierJoin type, otherwise it can't handle it.

This causes actually some issues with slow packaging loading times.

@roflmaostc
Copy link
Member Author

This affects also rft_pad, rft_fix_after.

@roflmaostc
Copy link
Member Author

I used this tool: https://aviatesk.github.io/JET.jl/stable/tutorial/

@report_opt ignored_modules=(AnyFrameModule(Base),) resample(x, (2,2))

@RainerHeintzmann
Copy link
Member

Ok. Will see if I can fix this.

@roflmaostc
Copy link
Member Author

fixed by #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants