Fourier join fix #30
Merged
Fourier join fix #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 93.26% 93.34% +0.07%
==========================================
Files 17 17
Lines 936 947 +11
==========================================
+ Hits 873 884 +11
Misses 63 63
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks for that. Did you check for type instabilities? |
|
See here: #29 |
roflmaostc
reviewed
Feb 3, 2023
roflmaostc
reviewed
Feb 5, 2023
|
Please revert all the tabbing changes (with a git revert). |
roflmaostc
reviewed
Feb 5, 2023
| # FFTs and other RFT dimension should use the version without L2 | ||
| function FourierSplit(parent::AA, D::Int,L1::Int,L2::Int) where {T,N, AA<:AbstractArray{T, N}} | ||
| return new{T,N, AA}(parent, D, L1, L2) | ||
| This version below is needed to avoid a split for the first rft dimension, |
There was a problem hiding this comment.
Tab the doc string in the case, I guess.
There was a problem hiding this comment.
should be fine now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a recursive type scheme. This seems to work now and the @report_opt seems to be happy, but there may be a cleaner or simpler way to achieve type stability.
Felix, can you do some speed test of the old and new scheme before merging?