Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug in rotate and added feature to remove wrap-around on shear! #22

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

RainerHeintzmann
Copy link
Member

.. also a little speed improvement in rotate() by using shear!() for the last two shears.

@RainerHeintzmann
Copy link
Member Author

In my tests, the test regarding fftshift!() failed. This function was removed? I replaced it with FourierTools/_fftshift!().

@roflmaostc
Copy link
Member

Yes, fftshift! was removed since it got recently added to AbstractFFTs making our implementation obsolete.

Thanks for fixing the test

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2022

Codecov Report

Merging #22 (7da1cfd) into main (4feb95c) will increase coverage by 0.63%.
The diff coverage is 92.00%.

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   95.61%   96.24%   +0.63%     
==========================================
  Files          14       14              
  Lines         729      745      +16     
==========================================
+ Hits          697      717      +20     
+ Misses         32       28       -4     
Impacted Files Coverage Δ
src/fourier_shear.jl 89.58% <88.88%> (-1.05%) ⬇️
src/fourier_rotate.jl 90.00% <100.00%> (ø)
src/nfft_nd.jl 90.00% <100.00%> (ø)
src/fftshift_alternatives.jl 100.00% <0.00%> (+24.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@roflmaostc roflmaostc merged commit 6598e68 into main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants