fixed a problem with czt which causes wrap-around. This had an effect… #31
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #31 +/- ##
==========================================
- Coverage 93.34% 93.01% -0.34%
==========================================
Files 17 17
Lines 947 959 +12
==========================================
+ Hits 884 892 +8
- Misses 63 67 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| FourierTools.upsample2 | ||
| FourierTools.upsample2_abs2 | ||
| FourierTools.upsample2_1D | ||
| FourierTools.barrel_pin | ||
| ``` |
There was a problem hiding this comment.
I'm actually against exporting all those functions. Some of them are rather internally (such as resample_by_RFFT).
So I would only export upsample2 and resample
There was a problem hiding this comment.
Why not "barrel_pin"? This is not internal.
There was a problem hiding this comment.
Ok for barrel_pin.
But rename it to something more expressive.
There was a problem hiding this comment.
I left barrel_pin in for export
There was a problem hiding this comment.
backward compatibility? What is wrong with the name?
There was a problem hiding this comment.
Yes, I was confused why GitHub indicated change of these lines.
Then we leave it but nevertheless.
How should one know that pin stands to pincushion and not for to pin.
Mainly it's a distortion, so something like: distort_radial would be more expressive
https://en.wikipedia.org/wiki/Distortion_(optics)#Radial_distortion
There was a problem hiding this comment.
we should leave it as is. 'pincushion' is described in the help and I find the name OK. Also we should not change it due to backwards compatibility issues.
|
As I said before, please always check the docstrings for proper formatting in the REPL. |
fixed a problem with czt which causes wrap-around. This had an effect on resample_czt.
There was also a problem with premature clipping when zooming but also extending the destination size.
See this examples: