feat: allow unary subtraction operator in SEDML validation #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #139 +/- ##
=======================================
Coverage 95.79% 95.79%
=======================================
Files 88 88
Lines 9399 9399
=======================================
Hits 9004 9004
Misses 395 395
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
moraru
approved these changes
May 19, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
updated software version to 0.1.178 in _version.py prior to merge so that it can be released and pushed to PyPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What new features does this PR implement?
While validating SEDML documents, the
evalidatelibrary is used to check mathematical expressions used in a SEDML document (e.g. withinFunctionalRangemath). This validation does not permit use of the unary subtract operator which is common and safe. This maps to the Python AST as 'USub'.What bugs does this PR fix?
This fixes the validation of several Virtual Cell models which use the unary subtract within its math. The SEDML validation encounters the use of unary subtract operator and raises a validation failure (a false-negative result).
Does this PR introduce any additional changes?
No.
How have you tested this PR?
added a test in
test_sedml_math.pywhich exercises this operator.