All reactions (not just reversible ones) have now forward_variable and r... #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d reverse_variable. Also the following major changes have been introduced: - reversible_encoding has been eliminated. Everything needs to use v_fwd - v_rev now to model the flux of a reaction. - reaction.variable is deprecated. Start using reactions.forward_variable All test miraculously pass ... which is weird. I anticipated flux_variability_analysis would fail because it is not using v_fwd - v_rev explicitily. It doesn't fail though because the objective is set with reactions and SolverBasedModel.objective = reaction will use v_fwd - v_rev
phantomas1234
added a commit
that referenced
this pull request
Apr 10, 2015
All reactions (not just reversible ones) have now forward_variable and r...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...everse_variable.
Also the following major changes have been introduced:
All test miraculously pass ... which is weird. I anticipated flux_variability_analysis would fail because it is not using v_fwd - v_rev explicitily. It doesn't fail though because the objective is set with reactions and SolverBasedModel.objective = reaction will use v_fwd - v_rev