Modify package structure #6
Conversation
| @@ -293,10 +290,10 @@ def core_stoichiometry(self): | |||
| return (rxn_var_name, stoichiometry_core) | |||
|
|
|||
| def update_thermo_variables(self): | |||
There was a problem hiding this comment.
Is there a better way to check if the new variables are added or not ?
There was a problem hiding this comment.
Since this pull request is only meant to upgrade the package structure, I'd like to tackle this question in a different issue/pull request, if that's okay?
There was a problem hiding this comment.
Yes, make sense. thanks
| for metabolite in self.metabolites: | ||
| if metabolite.Kegg_id in metabolite_accessions: | ||
| accessions[metabolite.id] = metabolite_accessions[ | ||
| accessions = {} |
There was a problem hiding this comment.
I think this function broke when the cache file was removed. As a temp fix I made this change. Could you check the function to properly do the cache file location
There was a problem hiding this comment.
Similarly to the previous comment I'd like to tackle this separately.
There was a problem hiding this comment.
Sure, At the moment it can't create a cache file, gets from equilibrator-api every time. I will comment out the cache file writing line for now to avoid error
|
Awesome 🙂 |
This introduces the new package structure and configuration as we have discussed @vishnumahamkali
I've tried to fix the example but the
tmodelconstructor changed quite a bit and I'm not completely sure how to adapt it.