Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pa-wmenu #19

Merged
merged 1 commit into from
Jun 16, 2024
Merged

add pa-wmenu #19

merged 1 commit into from
Jun 16, 2024

Conversation

arcxio
Copy link
Collaborator

@arcxio arcxio commented Jun 12, 2024

I was just going to add pa-wmenu as wmenu is the default Sway menu, but realized that most of the menu scripts are just copy-pasted and could be abstracted away to a generic script, so that's what I did.

The existing menu scripts are changed to call the new pa-menu and will still work after pulling if they are symlinked to the local pa repo.

@arcxio
Copy link
Collaborator Author

arcxio commented Jun 12, 2024

as a bonus, all of the menu scripts are now shellcheck compliant

@biox
Copy link
Owner

biox commented Jun 13, 2024

from my perspective, the scripts in contrib/ are meant to be standalone - i'll absolutely accept your shellcheck/pa-wmenu contributions, but abstracting these into a single pa-menu script is too much - lots of folks just copy & paste the thing most relevant to them and the pa-menu abstraction complicates that a little too much for my liking. sorry!!

@arcxio arcxio changed the title add pa-menu and pa-wmenu add pa-wmenu Jun 14, 2024
@arcxio
Copy link
Collaborator Author

arcxio commented Jun 14, 2024

that's fair, although I'd still like to suggest utilizing pa list in the existing scripts to make them simpler

@biox
Copy link
Owner

biox commented Jun 16, 2024

works for me!

@biox biox merged commit ab1fc36 into biox:main Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants