only one line after expand button #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasenlehara
approved these changes
Jul 23, 2019
| //Without trimming, additional characters can create new lines | ||
| //this happens when PrismJS is not applied (in testing) | ||
| //setting total to length - 1 makes the last not collapsed | ||
| codeBlock.textContent = codeBlock.textContent.trim(); |
There was a problem hiding this comment.
Is this the best place to do the trimming, or should it be done wherever codeBlock.textContent is initially created/set?
There was a problem hiding this comment.
Yeah, it could be trimmed initially in bit-docs-prettify
There was a problem hiding this comment.
@chasenlehara bit-docs-prettify is not invoked in testing, so I changed the fix to be the same as the needed part to remove the newline at the end.
test-collapse-last-line.md
Outdated
| @@ -0,0 +1,111 @@ | |||
| You can also set the `value` of the properties of `pageComponentViewModel` and verify that the `routeData` is updated correctly: | |||
There was a problem hiding this comment.
Is this needed for the test? Can this be pared down at all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trim code to prevent creating new line which causes to display one line after the expand button.
The logic:
1from the code lengthPrismJSadditional line is created because of"character at the end of the code, that's whytotalwas set tocodeLines.length - 1which makes one line (the last line of the code mostly) visible after the expand button.With this fix the same number of line of code is present before and after applying
PrismJS.Fixes #14