Demos should scale themselves to fit their content

[justinbmeyer]

The demos used to "grow" to contain all their content (up to 600 px high). We should bring that back:

[imaustink]

@justinbmeyer, the @demo tag seems to use an iframe for the preview. As far as I can tell, there is no event to listen for when the JavaScript has run within an iframe. The load event is the closest thing I can find thus far and is too early. The height of the iframe is always 150px on load since the render hasn't happened yet, so without doing some dirty checking, I don't believe this could work with an iframe.

I looked through the commit history and it looks like it's always used an iframe. Is it possible you are remembering this feature from something else or have I missed something?

[justinbmeyer]

It didn't use load other than to begin polling. You checked documentjs out?

…

Sent from my iPhone

On Apr 12, 2017, at 6:23 PM, Austin Kurpuis ***@***.***> wrote: The @demo tag seems to use an iframe for the preview. As far as I can tell, there is no event to listen for when the JavaScript has run within an iframe. The load event is the closest thing I can find thus far and is too early. The height of the iframe is always 150px on load since the render hasn't happened yet, so without doing some dirty checking, I don't believe this could work with an iframe. I looked through the commit history and it looks like it's always used an iframe. Is it possible you are remembering this feature from something else or have I missed something? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[imaustink]

Are you saying pollling/dirty checking is an acceptable solution for this?
Yes, I have looked at documentjs. As far as I can tell it doesn't use an iframe for the @demo tag. bit-docs' @demo tag definitely uses an iframe though.

[justinbmeyer]

It does use an iframe. here's where the polling happens: https://github.com/bitovi/documentjs/blob/master/site/default/static/demo_frame.js#L60

[justinbmeyer]

With modern browsers, there maybe better solutions to this. Nils's element resize library might be able to know when the body's dimensions changed (as opposed to the window's resize). Otherwise, polling is ok because it only needs to happen every second or so.

[imaustink]

Okay awesome, thanks! This is really helpful!