Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "special" chars in the identifiers #48

Closed
shochdoerfer opened this issue Aug 13, 2016 · 5 comments
Closed

Handle "special" chars in the identifiers #48

shochdoerfer opened this issue Aug 13, 2016 · 5 comments
Milestone

Comments

@shochdoerfer
Copy link
Member

While experimenting with Disco and Expressive I realized that currently Disco is not able to work with Expressive for one reason: Expressive uses pseudo class names to query service instances from the service container. Since Disco tries to call a method with the same name on the config class this currently does not work because "" is not a valid character to be used for a method name.

To solve the issue we need a mapper in between to translate the invalid characters into valid ones.

@dropdevcoding
Copy link
Contributor

Possibly this could be done with a more abstract mapper which I want to introduce in Adroit's ContainerResponderResolver. What do you think of discussing such a mapper as a separate "mini component"?

@shochdoerfer
Copy link
Member Author

I don't think that it would make sense to customize such a mapping. The constraints are clear, there is not much room for customizations I would think.

@dropdevcoding
Copy link
Contributor

Having an interface for such a mapper does not imply configurability of any of its implementations. You could use a fixed One for that use case.

@shochdoerfer
Copy link
Member Author

Well the point is if I can solve the problem with 3 lines of code why use some external lib for that?

@shochdoerfer shochdoerfer added this to the 0.5.0 milestone Aug 14, 2016
@dropdevcoding
Copy link
Contributor

Good point, if you don't see any need for customization, I agree.I thought of this possibility because the hard coded approach will require implicit knowledge about how this is done internally and may not be customized.

shochdoerfer added a commit to shochdoerfer/disco that referenced this issue Aug 16, 2016
shochdoerfer added a commit to shochdoerfer/disco that referenced this issue Aug 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants