Allow parameters in BeanPostProcessor configuration #101
Conversation
| foreach ($beanAnnotation->getAliases() as $beanAlias) { | ||
| $alias = $beanAlias->isTypeAlias() ? (string) $method->getReturnType() : $beanAlias->getName(); | ||
| if (empty($alias)) { | ||
| continue; |
There was a problem hiding this comment.
This if-block seems to be unreachable code, because it looks like an alias name, that can be empty, will throw an exception before the ConfigurationGenerator is reached.
There was a problem hiding this comment.
I added the check mostly for the return type. Potentially it could not be defined at this stage. Maybe it makes sense to move the BeanMethod generation logic upfront which actually checks for the return type.
There was a problem hiding this comment.
I'll try to cover it with a return type test.
There was a problem hiding this comment.
When I add a method without a return type into BeanConfigurationWithConflictingAliases, the empty check for the alias is covered. If I do the same in BeanConfigurationWithAliases, I get the expected "is missing the return type hint" Exception.
Allow passing parameters to the BeanPostProcessor configuration in a similar fashion as passing parameters to the Bean configuration.