#73 Adds setup for simple benchmarks #80
Conversation
These changes add a simple benchmark setup. This allows us to create and run the benchmark tests.
|
I started with this small setup. Let me know if there are features that I didn't cover |
There was a problem hiding this comment.
For an initial version it looks good, see my remarks for some minor changes. In addition to that I would love to see benchmarks for the different bean configuration options (singleton / non-singleton, lazy / non-lazy, alias) to see which impact the different configuration options have.
Do you have a good idea how to add the benchmarks to the README.md file? Since we have the "production tuning" section there it might be a good idea to include the benchmark results there somehow.
| /** | ||
| * @Bean | ||
| */ | ||
| public function mySimpleService() : A { |
There was a problem hiding this comment.
For consistency reasons the method should be named A. You could define "mySimpleService" as alias. That way we could also run a bechmark trying to retrieve beans by the alias.
| /** | ||
| * @Bean | ||
| */ | ||
| public function B() : B { |
There was a problem hiding this comment.
Please use the PSR-2 standard for formatting the configuration class.
| /** | ||
| * @Configuration | ||
| */ | ||
| class MyConfiguration |
There was a problem hiding this comment.
Better rename the class to BenchmarkConfiguration so that it is clear what the purpose of the class is.
| \bitExpert\Disco\BeanFactoryRegistry::register($this->disco); | ||
| } | ||
|
|
||
| public function benchCreateInstance() |
There was a problem hiding this comment.
For consistency reasons the method should be named benchCreateSimple()
|
phpbench supports reporting to markdown, so it will be very easy to add those results to the readme. I will have a look at your requested changes and add more benchmarks for other cases. Glad you like the initial setup. |
Fixes number of psr2 issues and clearified some class and method naming for consistency
Report for github can be generated using the command below `vendor/bin/phpbench run --report=aggregate -o github`
|
|
||
| public function benchCreateSimpleAliased() | ||
| { | ||
| $this->disco->get('mySimpleService'); |
There was a problem hiding this comment.
For some reason this bench will run forever.
There was a problem hiding this comment.
Seems to work fine for me. Which PHP version did you use to run the test?
jaapio
changed the title
|
I used php7.0 not sure about the exact version
Op zo 11 dec. 2016 13:43 schreef Stephan Hochdörfer <
notifications@github.com>:
… ***@***.**** commented on this pull request.
------------------------------
In benchmarks/Bench/BaseObjectCreation.php
<#80>:
> +
+use bitExpert\Disco\BeanFactory;
+
+abstract class BaseObjectCreation
+{
+ /** @var BeanFactory */
+ protected $disco;
+
+ public function benchCreateSimple()
+ {
+ $this->disco->get('A');
+ }
+
+ public function benchCreateSimpleAliased()
+ {
+ $this->disco->get('mySimpleService');
Seems to work fine for me. Which PHP version did you use to run the test?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#80>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABAuUXfAf4vhJXrCqaQAh936vVdTFw3qks5rG_AMgaJpZM4LGu4R>
.
|
These changes add a simple benchmark setup.
This allows us to create and run the benchmark tests.
Releated to #73