Skip to content

Conversation

szepeviktor
Copy link
Contributor

less characters :)

@szepeviktor
Copy link
Contributor Author

Nowdoc would be even nicer.

$template = <<<'EOD'
class
{
    ...
}
EOD;

@shochdoerfer
Copy link
Member

Sorry, but I don't see the point of using an array and imploding it to save a few characters. If that's your take then we would need to rename each and every variable and class to save characters.

Nowdoc sounds fine to me. Back when I added the string concatenation I was not aware that Heredoc/Nowdoc behaviour was changed in PHP 7.3 to support whitespaces before the closing tag. Back in the days when I used Heredoc last this was not the case.

If you want to update the PR to support Nowdoc I am fine, otherwise, I just close it.

@szepeviktor
Copy link
Contributor Author

You've seen my code, that is enough for me.

@szepeviktor szepeviktor deleted the patch-2 branch February 11, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants