Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nokogiri gem #5

Closed
wants to merge 3 commits into from
Closed

Update nokogiri gem #5

wants to merge 3 commits into from

Conversation

jepzen
Copy link

@jepzen jepzen commented May 11, 2014

Hi

I had to change the reference to a newer version of nokogiri to make it work.

Removed a require in spec_helper to make the test work.

And corrected the example to use upload instead of add for updating prices. As mentioned in one issue

This is my first pull requests ever so let me know if i am doing it all wrong. And thanks for the gem!

@sean-devmode
Copy link
Contributor

I've addressed the issues you were running into as well as others in a separate commit. I've made the gemspec dependency declarations more flexible so they should align with your project's nokogiri requirements. I've also eliminated deprecation warnings and made it much easier to get the project building and tests running from an initial clone. There is a 0.0.4 version published to rubygems to reflect these changes.

@sean-devmode
Copy link
Contributor

One suggestion regarding future pull requests would be to use rebase -i to squash your commits into a single before submitting the pull request. Otherwise, thanks for contributing and I hope the new version suits your needs well.

@jepzen
Copy link
Author

jepzen commented May 12, 2014

Yes it works great. Thanks a lot!

@jepzen jepzen deleted the update-nokogiri-gem branch May 12, 2014 21:05
vaibhavdabhade pushed a commit to Anchanto/mws that referenced this pull request Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants