Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: infinite scroll issue on bot view #212

Merged
merged 1 commit into from
May 7, 2024

Conversation

TopETH
Copy link
Member

@TopETH TopETH commented May 6, 2024

Summary by CodeRabbit

  • Bug Fixes
    • Improved pagination in the ThreadList component to ensure correct offset calculation.
    • Refined the logic for loading more threads based on the length of the last page, enhancing user experience in thread navigation.

@TopETH TopETH self-assigned this May 6, 2024
Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
masterbots ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 10:45pm

Copy link
Contributor

coderabbitai bot commented May 6, 2024

Walkthrough

The recent update enhances the ThreadList component by fine-tuning the pagination mechanics. The offset for fetching threads is now calculated more accurately, starting from zero on the first page. Additionally, the conditions for triggering the loading of additional thread pages have been improved to better handle scenarios where the last page's thread count varies.

Changes

File Path Change Summary
.../shared/thread-list.tsx Adjusted offset calculation and refined thread loading logic

🐇✨
In the code's woven nest, a tweak,
Pagination now sleek as a creek.
When threads grow fewer,
Load more is truer,
A rabbit's work, unique and chic!
🌟🐾


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 2d9dde0 and fe60e3b.
Files selected for processing (1)
  • apps/masterbots.ai/components/shared/thread-list.tsx (2 hunks)
Additional comments not posted (2)
apps/masterbots.ai/components/shared/thread-list.tsx (2)

38-38: Correct adjustment of the offset calculation to align with typical pagination patterns.


61-65: Improved logic for loading more items based on the length of the last page of threads. Ensure to add a null check for loadMoreRef.current to avoid potential errors.

Copy link

github-actions bot commented May 6, 2024

⚡️ Lighthouse report

Page: https://masterbots-o6wjte39k-bitcash.vercel.app/
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1715035958757-75929.report.html

Category Score
🔴 Performance 47
🟢 Accessibility 96
🟠 Best practices 78
🟠 SEO 85
🔴 PWA 38

Page: https://masterbots-o6wjte39k-bitcash.vercel.app/b/moneybot
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1715035959402-10591.report.html

Category Score
🟠 Performance 54
🟢 Accessibility 95
🟠 Best practices 78
🟠 SEO 85
🔴 PWA 38

Page: https://masterbots-o6wjte39k-bitcash.vercel.app/u/slug-1
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1715035959690-4678.report.html

Category Score
🟠 Performance 53
🟢 Accessibility 94
🟠 Best practices 78
🟠 SEO 83
🔴 PWA 38

Page: https://masterbots-o6wjte39k-bitcash.vercel.app/p
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1715035959935-97460.report.html

Category Score
🟠 Performance 59
🟢 Accessibility 92
🟠 Best practices 78
🟠 SEO 76
🔴 PWA 38

Page: https://masterbots-o6wjte39k-bitcash.vercel.app/health
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1715035960218-67238.report.html

Category Score
🟠 Performance 57
🟠 Accessibility 59
🟠 Best practices 74
🔴 SEO 42
🔴 PWA 13

Page: https://masterbots-o6wjte39k-bitcash.vercel.app/health/a8103808-14a3-48ed-aa5a-9e490cfdcf0e
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1715035960482-65583.report.html

Category Score
🟠 Performance 58
🟠 Accessibility 59
🟠 Best practices 74
🔴 SEO 42
🔴 PWA 13

Copy link
Contributor

@AndlerRL AndlerRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice catch on the logic for the infinite scroll! The changes makes sense. Merging! 👍

@AndlerRL AndlerRL merged commit 4b739c2 into alpha May 7, 2024
4 checks passed
@AndlerRL AndlerRL deleted the topeth/fix-infinite-scroll-issue-on-bot-view branch May 7, 2024 15:44
@AndlerRL
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants