add build scripts w/o gui #561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of a new script, I would prefer if an option were just added to the existing script(s) that would disable the qt build. |
achow101
added a commit
that referenced
this pull request
Jan 3, 2023
f6d246a Typo (Kiminuo) 56e541f `contrib/build_bin.sh` and `contrib/build_bin.sh` now accepts `--without-gui` as their first parameters to build without the GUI support. (Kiminuo) Pull request description: Alternative to #561 Addresses #561 (comment): > Instead of a new script, I would prefer if an option were just added to the existing script(s) that would disable the qt build. ACKs for top commit: achow101: ACK f6d246a Tree-SHA512: fbce40b6d21c3523b747439e7018153b18589e736aae717bced28e42af4c12f0104afead537683e5d9d027e64023f728d3e6803fc95cfd21b6871c4cb1984d6a
|
Should this PR be closed given that #655 was merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds scripts to build HWI without the QT GUI.
Still needs to remove
{ include = "hwi-qt.py" },from L14 andhwi-qt = 'hwilib._gui:main'from L46 inpyproject.toml