Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases: add 0.17.0.1 #624

Merged
merged 3 commits into from
Oct 30, 2018
Merged

Conversation

harding
Copy link
Contributor

@harding harding commented Oct 26, 2018

Preview: http://dg1.dtrt.org/en/releases/0.17.0.1/ & http://dg1.dtrt.org/en/download/

Todo:

  • Set correct date: in release notes
  • Add magnet URI to release notes

Both can be safely done after the merge, if desired.

Release notes include an extra sentence not in the original and a link to the 0.17.0 release notes, as discussed earlier today on IRC.

Note: Travis build expected to fail until binaries have been uploaded.

Copy link
Contributor

@jnewbery jnewbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change suggestion. Otherwise looks good.


<https://bitcoincore.org/bin/bitcoin-core-0.17.0.1/>

This is a new major version release, including new features, various bugfixes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this say "This is a minor bug fix for 0.17.0." (compare https://bitcoincore.org/en/releases/0.15.0.1/)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed upstream and here, thanks!

maflcko pushed a commit to bitcoin/bitcoin that referenced this pull request Oct 28, 2018
f046d84 Docs/Release notes: 0.17.0.1 is a minor release (David A. Harding)

Pull request description:

  Suggested by @jnewbery in bitcoin-core/bitcoincore.org#624 (review)

Tree-SHA512: 7e3068febaaf13cc31ef48e56ac7c36450fb1fb115e9940af603bb7cb740e93702e69be0eaaf06ff19866837bf29b4f08c1d9e3e55d98a65746a89a0dcab2b69
Copy link
Contributor

@jnewbery jnewbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK eb6c5e7

@laanwj
Copy link
Member

laanwj commented Oct 30, 2018

ACK
Added magnet link and updated date

@laanwj laanwj merged commit 789777c into bitcoin-core:master Oct 30, 2018
laanwj added a commit that referenced this pull request Oct 30, 2018
789777c Add magnet link and update release date for 0.17.0.1 (Wladimir J. van der Laan)
eb6c5e7 Releases: link to 0.17.0 in 0.17.0.1 release notes (David A. Harding)
f9d49f4 Releases: add 0.17.0.1 (David A. Harding)

Pull request description:

  Preview: http://dg1.dtrt.org/en/releases/0.17.0.1/ & http://dg1.dtrt.org/en/download/

  Todo:

  - [x] Set correct `date:` in release notes
  - [x] Add magnet URI to release notes

  Both can be safely done after the merge, if desired.

  Release notes include an extra sentence not in the original and a link to the 0.17.0 release notes, as discussed earlier today on IRC.

  Note: Travis build expected to fail until binaries have been uploaded.

Tree-SHA512: fcbc996adc4dee1b4f465938000026f08b9c985ac38142652713ffa05efcfe9309a7e0364fe58f892a5252624dd8cfb5c7c7188a3dbde9a2d729b494e417aa1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants